Skip to content

fix(unicode): count bytes not characters#195

Merged
Gioee merged 12 commits intomainfrom
#192-Bind-valiable-with-multi-byte-character
Feb 4, 2025
Merged

fix(unicode): count bytes not characters#195
Gioee merged 12 commits intomainfrom
#192-Bind-valiable-with-multi-byte-character

Conversation

@danielebriggi
Copy link
Copy Markdown
Member

#192

Message length was counted in character instead of bytes.

@danielebriggi danielebriggi requested a review from Gioee February 3, 2025 17:35
@danielebriggi danielebriggi self-assigned this Feb 3, 2025
@danielebriggi danielebriggi force-pushed the #192-Bind-valiable-with-multi-byte-character branch from 19b0d86 to d1819ba Compare February 3, 2025 19:10
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.26%. Comparing base (490844e) to head (76e8d0a).
⚠️ Report is 90 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #195      +/-   ##
==========================================
- Coverage   87.35%   87.26%   -0.09%     
==========================================
  Files          11       11              
  Lines         973      974       +1     
  Branches      286      286              
==========================================
  Hits          850      850              
- Misses        123      124       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Gioee Gioee merged commit fb677a0 into main Feb 4, 2025
@Gioee Gioee deleted the #192-Bind-valiable-with-multi-byte-character branch February 4, 2025 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants